searcher: use debug server readiness endpoint - #478
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a0695f-be00-74df-9488-895b355a0c4c Co-authored-by: Amp <amp@ampcode.com>
bobheadxi
approved these changes
Sep 4, 2026
eseliger
enabled auto-merge (squash)
September 4, 2026 14:57
eseliger
disabled auto-merge
September 4, 2026 14:57
eseliger
added a commit
to sourcegraph/deploy-sourcegraph-docker
that referenced
this pull request
Sep 4, 2026
Update the searcher container healthcheck to use its readiness-gated debugserver endpoint at `http://127.0.0.1:6060/ready` instead of `http://127.0.0.1:3181/healthz`. Sister changes: - [deploy-sourcegraph-helm#938](sourcegraph/deploy-sourcegraph-helm#938) - [deploy-sourcegraph-k8s#478](sourcegraph/deploy-sourcegraph-k8s#478) ### Checklist * [x] All images have a valid tag and SHA256 sum ### Test plan - Ran `.buildkite/validate-docker-compose.sh` with Docker Compose 1.29.2; configuration validation passed. - Ran `yarn -s run prettier --write=false`; formatting passed. - The coordinated Helm change was validated with a real searcher container in a disposable kind cluster: Kubernetes marked it Ready and an in-cluster request to `/ready` returned HTTP 200.
eseliger
enabled auto-merge (squash)
September 4, 2026 14:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/readyendpointgrpcandhttp-debugnamed ports for 3181 and 6060Mirrors deploy-sourcegraph-helm#938.
Compatibility
Custom consumers that reference the searcher Service ports by their old names (
httpordebug) must update togrpcorhttp-debug. Numeric ports remain unchanged.