Skip to content

fix: split shell exec pattern for terminal file picker on Windows #2637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weiningwei wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −1
Open

fix: split shell exec pattern for terminal file picker on Windows #2637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Views/Preferences.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,11 @@ private async void SelectShellOrTerminal(object _, RoutedEventArgs e)
{
options = new FilePickerOpenOptions()
{
FileTypeFilter = [new FilePickerFileType(shell.Name) { Patterns = [shell.Exec] }],
FileTypeFilter = [new FilePickerFileType(shell.Name)
{
Patterns = shell.Exec.Split('|',
StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)
}],
Comment on lines +344 to +348

@Mingun Mingun Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would beter to change shell.Exec type from String (?) to String[] if that possible.

AllowMultiple = false,
};
}
Expand Down