Search v20 fixes - #75
Merged
Merged
Conversation
|
|
||
| <mat-form-field appearance="outline" class="toolbar-search-select"> | ||
| <mat-icon matSuffix [className]="config.dropDownButtonIconClass"></mat-icon> | ||
| <!-- <mat-icon matSuffix [className]="config.dropDownButtonIconClass"></mat-icon> --> |
| "@angular/platform-browser-dynamic": "^20.0.3", | ||
| "@angular/router": "^20.0.3", | ||
| "@sourceloop/search-client": "^9.0.1", | ||
| "@sourceloop/search-client": "file:../../packages/search/projects/search-lib/dist", |
Collaborator
There was a problem hiding this comment.
We need to update this later on mention the steps to run the sandbox
Contributor
Author
There was a problem hiding this comment.
yes once released will update the version
| "build:search": "cd packages/search && npx ng build search-lib", | ||
| "link:search": "npm run build:search && cd packages/search/projects/search-lib/dist && npm link && cd ../../../../../sandbox/search-client-example && npm link @sourceloop/search-client", | ||
| "watch:search": "cd packages/search && npx ng build search-lib --watch", | ||
| "start:search-sandbox": "cd sandbox/search-client-example && npm start" |
Collaborator
There was a problem hiding this comment.
Lets update how to use this in developing.md file
Contributor
Author
There was a problem hiding this comment.
will do this for the master branch
this is for angular 20, the current version that we support is angular v21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed flex layout
updated the styles after material upgrade
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: