Repository navigation
[BUGFIX] Return creation and modification date stored by TYPO3 - #170
Merged
Merged
Conversation
Extbase sets TCA `ctrl.crdate` and `ctrl.tstamp` only in the database row, so after POST, PUT and PATCH the persisted object still held old values (e.g. `null` for a new record). Models with non-nullable getters (e.g. `News::getCrdate(): DateTime` in EXT:news) failed during response serialization with HTTP 500, although the record was already saved. After persisting, stored creation and modification dates are copied from the database to the object. Values are mapped the same way as Extbase maps them when loading the object (including typed properties which are not initialized, empty timestamps and the `extbase.consistentDateTimeHandling` feature), so the response of write operations is the same as the response of subsequent GET.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extbase sets TCA
ctrl.crdateandctrl.tstamponly in the database row, so after POST, PUT and PATCH the persisted object still held old values (e.g.nullfor a new record). Models with non-nullable getters (e.g.News::getCrdate(): DateTimein EXT:news) failed during response serialization with HTTP 500, although the record was already saved.After persisting, stored creation and modification dates are copied from the database to the object. Values are mapped the same way as Extbase maps them when loading the object (including typed properties which are not initialized, empty timestamps and the
extbase.consistentDateTimeHandlingfeature), so the response of write operations is the same as the response of subsequent GET.