Repository navigation
Replace the integration tests with the conformance oracle - #2633
Merged
somewhatabstract merged 3 commits intoOct 23, 2026
Conversation
The conformance oracle runs the same examples through the real CLI, so the in-process integration tests are now redundant. Removes them, their log generator and support module, and the test:integration script, and moves example discovery into the conformance harness. `pnpm test` now runs the unit tests and the conformance oracle. Part of #2613. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QjLhVH1NnUc7MzCSYLd8Yn
🦋 Changeset detectedLatest commit: 5ee3f95 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## claude/jolly-galileo-72zesp-conformance-cache #2633 +/- ##
===============================================================================
Coverage 100.00% 100.00%
===============================================================================
Files 51 51
Lines 1011 959 -52
Branches 249 231 -18
===============================================================================
- Hits 1011 959 -52
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Removing the integration test support module dropped the only coverage of combining the migration mode from arguments with config mappings in determineOptions, and of the default migration mode in loadMigrationConfig. Adds direct unit tests for both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QjLhVH1NnUc7MzCSYLd8Yn
The config type requires a mode, but parsed config files can omit it, which is the case the default exists for, so the test input is cast. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QjLhVH1NnUc7MzCSYLd8Yn
3 of 6 tasks
somewhatabstract
deleted the
claude/jolly-galileo-72zesp-replace-integration-tests
branch
October 23, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The conformance oracle (#2622, #2625) runs the same
__examples__through the real, built CLI, so the in-process integration tests are now redundant. This PR removes them, leaving one end-to-end test suite.Stack
Issues
Part of #2613 (Phase 0), which is under #2524.
Details
src/__tests__/integration.test.tsand its snapshot,src/integration-test-support.tsand its tests, andbin/gen-integration-test-logs.ts.getExamplesmoves into the harness assrc/conformance/get-examples.ts, with its own tests. It now takes the examples directory as a parameter rather than finding it withancesdir.package.json:test:integrationandcoverage:integrationtest:unitandcoverage:unitno longer need to excludeintegration.test.tspnpm testnow runs the unit tests and then the conformance oraclepnpm test:conformance..gitignore: dropped.integrationtests/.What's no longer covered, on purpose
--verbosetext: we decided the Rust version only needs equivalent verbose output (Proposal: rewrite checksync in Rust, distributed as a binary-backed npm package #2524, fidelity contract item 7). Record marker cache files in the conformance oracle #2625's cache goldens cover file selection and checksums instead.--from-cache: the old scenarios read marker data back from the cache. I tried an oracle case for it: the output was identical to a normal run apart from one "Loading cache from…" line. You're happy for 12.0.0 to drop--from-cache, so I left it out rather than pin behavior that's going away. The 11.x code is otherwise unchanged.Review notes
Generated by Claude Code