Fix content disposition so downloads actually download - #1180
Open
TheSpyder wants to merge 2 commits into
Open
Conversation
… Added a bunch of tests. Fixes solidtime-io#1148.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets the
content-dispositionheader toattachmentfor exported reports. Builds on the initial PR #1171, with the local fix proposed in #1148 and better tests.I admit that I'm not an expert in any of this code, but I know enough basic PHP that I think the logic is correct. I certainly questioned Claude a lot along the way. The tests all pass and I've manually verified both local and S3 exports on Chrome and Safari.
Checklist (DO NOT REMOVE)