fix: handle rejected module promises in lazy() - #2955
Open
birkskyum wants to merge 1 commit into
Open
Conversation
On the server `lazy()` attached only a success handler to the module promise. When the promise rejected, the Suspense boundary's `_loading` flag was never cleared, so `notifySuspense` never fired, the registered fragment never resolved and `renderToStream` never called `end()`: the response hung open and the error never reached an enclosing `ErrorBoundary`. Without a host `unhandledRejection` handler the un-caught `.then` in `load` crashed the process instead. The rejection is now recorded next to the resolved module, the boundary is notified so the fragment resolves, and the error is thrown where the component renders so `ErrorBoundary` can catch it. The client's hydration branch had the same success-only handler, leaving `sharedConfig.count` pinned and swallowing the error. It now decrements the count and surfaces the rejection to the nearest `ErrorBoundary`. SSR had no test harness, so this adds a second vitest project that resolves `solid-js` to the server entries. Closes solidjs#2945
🦋 Changeset detectedLatest commit: cc9a3a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the server
lazy()attached only a success handler to the module promise. When the promise rejected, the Suspense boundary's_loadingflag was never cleared, sonotifySuspensenever fired, the registered fragment never resolved andrenderToStreamnever calledend(): the response hung open and the error never reached an enclosingErrorBoundary. Without a hostunhandledRejectionhandler the un-caught.theninloadcrashed the process instead.The rejection is now recorded next to the resolved module, the boundary is notified so the fragment resolves, and the error is thrown where the component renders so
ErrorBoundarycan catch it.The client's hydration branch had the same success-only handler, leaving
sharedConfig.countpinned and swallowing the error. It now decrements the count and surfaces the rejection to the nearestErrorBoundary.SSR had no test harness, so this adds a second vitest project that resolves
solid-jsto the server entries.