Skip to content

fix(dev-server): delegate preview to Nitro when building with Nitro v3 #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkskyum merged 3 commits into from
Aug 18, 2026
+9 −0
Merged

fix(dev-server): delegate preview to Nitro when building with Nitro v3 #2294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4709e15
fix(dev-server): delegate preview to Nitro when building with Nitro v3
waterWang Aug 16, 2026
01622c9
fix(dev-server): detect Nitro preview ownership
birkskyum Aug 18, 2026
76ad73d
style: clarify Nitro preview comment
birkskyum Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-preview-owners.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

Delegate `vite preview` to Nitro when its preview plugin is active, including for static builds that intentionally have no server entry.
4 changes: 4 additions & 0 deletions packages/start/src/config/dev-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ export function devServer(serverEntryPath: string): Array<PluginOption> {
{
name: "solid-start-dev-server",
configurePreviewServer(server) {
// Nitro's preview hook handles both server and static builds.
// Static builds have no server entry, so detect the active plugin instead.
if (server.config.plugins.some(plugin => plugin.name === "nitro:preview")) return;

const serverEntryUrl = pathToFileURL(resolvePreviewServerEntry(server.config.root)).href;

return () => {
Expand Down
Loading