Skip to content

fix(scroll): prevent scroll on document to keep sticky elements#997

Open
jer3m01 wants to merge 1 commit into
solidjs-community:nextfrom
jer3m01:fix/scroll
Open

fix(scroll): prevent scroll on document to keep sticky elements#997
jer3m01 wants to merge 1 commit into
solidjs-community:nextfrom
jer3m01:fix/scroll

Conversation

@jer3m01

@jer3m01 jer3m01 commented Jul 21, 2026

Copy link
Copy Markdown
Member

Fixes layout shifts from sticky elements in prevent scroll.

Original report kobaltedev/kobalte#698.
Fix on corvu corvudev/corvu#107.

Moves hidden overflow from body to documentElement, same as react-aria.

Tested working without breaking changes in Firefox 152.0.6 W11 and Edge 150.0.4078.83 W11.

@changeset-bot

changeset-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f1a3158

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6138cf4a-a14f-4b43-a4bb-9bd0010fc0d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant