Skip to content

Fix/storage sync url#994

Merged
davedbase merged 2 commits into
nextfrom
fix/storage-sync-url
Jul 20, 2026
Merged

Fix/storage sync url#994
davedbase merged 2 commits into
nextfrom
fix/storage-sync-url

Conversation

@atk

@atk atk commented Jul 19, 2026

Copy link
Copy Markdown
Member

fixes #703

@changeset-bot

changeset-bot Bot commented Jul 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f534e3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-primitives/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@atk
atk changed the base branch from main to next July 19, 2026 16:25
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5f642c8a-8165-4a13-a8ce-174aa8b23d4b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/storage-sync-url

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zobweyt

zobweyt commented Jul 19, 2026

Copy link
Copy Markdown

Now you can only change the url itself, right? If I want the synchronization to work on tabs with different paths, then I can't do that? At least I don't see this case in the added tests

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying solid-primitives with  Cloudflare Pages  Cloudflare Pages

Latest commit: f534e3b
Status:⚡️  Build in progress...

View logs

@davedbase
davedbase merged commit b0b4f2e into next Jul 20, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[storage] The messageSync is not syncing between multiple browser tabs on different paths

3 participants