chore: upgrade to Vite 7 or possibly 8#966
Conversation
|
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
70-72: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueInconsistent version pinning style.
viteis pinned exactly (7.1.11) whilevitestretains a caret range (^3.2.6). Given the PR itself is exploratory (Vite 7 known to break tests), pinningviteexactly makes sense to avoid an unexpected minor/patch bump masking further regressions, but consider applying the same exact-pin discipline tovitestfor consistency, or restoring the caret onviteonce compatibility is confirmed.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` around lines 70 - 72, The dependency versions in package.json use mixed pinning styles, with vite exact-pinned and vitest still using a caret range. Update the version entries for vite and vitest to follow the same pinning policy, using the package names in package.json as the reference points, so the test/runtime toolchain stays consistent and does not drift unexpectedly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@package.json`:
- Around line 70-72: The dependency versions in package.json use mixed pinning
styles, with vite exact-pinned and vitest still using a caret range. Update the
version entries for vite and vitest to follow the same pinning policy, using the
package names in package.json as the reference points, so the test/runtime
toolchain stays consistent and does not drift unexpectedly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 8673839b-d48b-4d6d-b295-edf37b43216d
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
# Conflicts: # package.json # pnpm-lock.yaml
1 participant
This is an early attempt at bumping the Vite version. 8 definitely is not compatible for a number of reasons. 7 is working however it's causing a number of tests to fail which need to be investigated.
Warning
This is not to be merged yet. There's an issue with Storybook and Typescript compiling ts. pnpm storybook
/build-storybookremains broken — pre-existing onnext, caused by TypeScript 7.0's Go rewrite not yet exposing the classic Compiler API (ts.JsxEmitetc.) thatstorybook-solidjs-vite's docgen needs. No viable workaround exists via pnpm overrides since it's a peer-dep edge, not a regular one. The only real fixes are: wait for TS 7.1 (official fix, ~3-4 months out), or downgrade the workspace's realtypescriptto^6.x` (which you said you don't want to do right now).