Skip to content

fix: clean up v2 templates list #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nerdchanii wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −6
Open

fix: clean up v2 templates list #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1650fff
fix: clean up v2 templates list
nerdchanii Jul 13, 2026
64a6011
fix: remove with-tanstack-router from v2 templates list
nerdchanii Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/create/src/utils/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ const START_TEMPLATES = [
"with-prisma",
"with-solid-styled",
"with-tailwindcss",
"with-tanstack-router",
"with-trpc",
"with-unocss",
"with-vitest",
Expand All @@ -86,21 +85,19 @@ export type StartTemplate = (typeof START_TEMPLATES)[number];
const START_TEMPLATES_V2 = [
"basic",
"bare",
"with-solidbase",
"hackernews",
"notes",
"with-auth",
"with-authjs",
"with-drizzle",
"with-mdx",
"with-prisma",
"with-solid-styled",
"with-solidbase",
"with-strict-csp",
"with-tailwindcss",
"with-tanstack-router",

@brenelz brenelz Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i actually don't think the with-tanstack-router one works at the moment

@nerdchanii nerdchanii Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i actually don't think the with-tanstack-router one works at the moment

Thank you for the comment.

I tested the template and confirmed the issue as you mentioned (CSR works fine, but an error occurs on the SSR path).

Would it be better to only include fully functional templates here? I think this comes down to the Solid community's UX goals and philosophy, so I'd love to hear your thoughts.

I originally opened this PR to sync the template list between the v2 templates list and this Repository.

What would be the best way forward?
Personally, if removing this line is the recommended approach, I think closing this PR and opening a fresh one might be healthier for context hygiene (especially considering future AI workflow).

So, I think we can choose two options:

  1. Comment out or remove with-tanstack-router from the list
  2. Update the with-tanstack-router template

P.S. Although option 2 should probably be treated as a separate issue from this PR, I've investigated the root cause and put together a fix. I'll leave those details in a separate comment below.

@brenelz brenelz Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just remove the with-tanstack-router from t he list would be fine

@nerdchanii nerdchanii Jul 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR to remove with-tanstack-router from the list. I left the deep-dive analysis and potential fixes in the comment below as well

"with-trpc",
"with-unocss",
"with-vitest",
"with-strict-csp",
"with-tanstack-router",
] as const satisfies string[];

export type StartTemplateV2 = (typeof START_TEMPLATES_V2)[number];
Expand Down