feat: 커뮤니티 사용자 차단 분리#549
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Warning Review limit reached
More reviews will be available in 22 minutes and 3 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 990e2364b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const authorId = post.postFindSiteUserResponse?.id; | ||
|
|
||
| if (typeof authorId === "number" && blockedUserIdSet.has(authorId)) { |
There was a problem hiding this comment.
Require author IDs before relying on block filters
When the /boards/{boardCode} list payload does not include postFindSiteUserResponse (the repository’s current board-list shape in apps/web/src/apis/community/api.ts only defines id/title/content/counts/category/thumbnail for this endpoint), authorId is undefined and every blocked author’s post passes this filter. In that scenario, after blocking someone from a post detail the app routes back to the list but still renders that author’s posts, so the new local block feature only works on detail/comment data that has author IDs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
반영했습니다. 목록 응답에 작성자 ID가 없을 때도 차단을 누른 현재 게시글은 다시 노출되지 않도록 blockedPostIds를 저장하고, 목록/상세 가드에서 함께 필터링하도록 보완했습니다.
관련 이슈
작업 내용
차단하기액션을 추가했습니다.차단하기할 수 있도록 추가했습니다.특이 사항
/users/block/{blockedId})를 호출합니다.22.x, 현재 로컬은23.10.0입니다.리뷰 요구사항 (선택)
차단하기후 해당 작성자의 콘텐츠가 즉시 보이지 않는지 확인 부탁드립니다.검증
pnpm --filter @solid-connect/web run lint:checkpnpm --filter @solid-connect/web run typecheck:ci