Migrate JS tests to a Kit client and LiteSVM#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the feature-gate JS client tests to a Kit plugin client running on LiteSVM in-process instead of a local validator. The test
_setupbuilds the client viacreateClient().use(...)and loads the program.sointo LiteSVM withaddProgramFromFile, and the placeholder test is replaced with a smoke test that exercises the wiring. The validator script and Makefile targets are dropped, and a pre-existing Makefile pattern-ordering issue is fixed somake test-js-clients-jsresolves to the JS rule rather than the Rusttest-%rule.