Repository navigation
Fix passing incomplete body to parsers on connection abruptly closed - #5573
Merged
Merged
Conversation
Member
|
This is an automated review. The fix works for the Netty Future and Sync servers: a truncated body no longer reaches the codec. But #4169 is not fully fixed yet:
Minor:
|
added 11 commits
October 8, 2026 09:34
rwalerow
force-pushed
the
fix/pass-down-incomplete-body-on-connection-loss
branch
2 times, most recently
from
October 8, 2026 13:22
e39fd75 to
2c942a2
Compare
rwalerow
force-pushed
the
fix/pass-down-incomplete-body-on-connection-loss
branch
from
October 8, 2026 13:22
2c942a2 to
edbf85b
Compare
Member
|
This is an automated review (follow-up, at All points from the previous review are addressed. Checking the length in Remaining, minor:
|
…ncomplete body tests Sync multipart passes Netty chunks through ox again, releasing the ones left unconsumed when the flow ends early (ox drops buffered elements on errors). The incomplete body test waits for the request to be rejected instead of a fixed sleep, checks the failure's cause where it is observable, and covers multipart.
- document CopyingPublisher, IncompleteRequestBodyException, and that truncated chunked requests aren't detected - unit tests: drop a duplicate case, move the no Content-Length case to a SimpleSubscriber test, fail on a timeout instead of hanging - drop an unused socket helper in the fs2 interrupted test
It now also validates the body's length, not only tracks subscriptions.
…ests Points to softwaremill/ox#528, which would make the tracker unnecessary.
The other Netty servers cancel request processing when the connection closes, so these tests could not fail there.
…bled With interruption enabled (the default), request processing is cancelled before a truncated body is decoded. The tests now wait until request processing starts, as Sync skips requests whose connection closed before that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the last part of #4169
When client send partially declared body and than connection closes for any reason
Server reports issue and clears already read request and proceeds with a regular operation.