Skip to content

Feat/rnaa 474 playbacknotification configurable ffrw time#1165

Merged
basiav merged 10 commits into
mainfrom
feat/rnaa-474-playbacknotification-configurable-ffrw-time
Jul 15, 2026
Merged

Feat/rnaa 474 playbacknotification configurable ffrw time#1165
basiav merged 10 commits into
mainfrom
feat/rnaa-474-playbacknotification-configurable-ffrw-time

Conversation

@basiav

@basiav basiav commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Closes RNAA-474

⚠️ Breaking changes ⚠️

Introduced changes

Introduced changes

  • Added optional skipInterval to PlaybackNotificationInfo so apps can configure fast-forward/rewind skip duration in PlaybackNotificationManager.show() (default: 15 seconds).
  • iOS: Store skip interval in PlaybackNotification, read it from show() options, and apply it to MPRemoteCommandCenter preferredIntervals for skip forward/backward commands.
  • Android: Store skip interval in a shared companion property; use it in MediaSession callbacks (onFastForward / onRewind) and in PlaybackNotificationReceiver (notification action buttons).
  • Clamp skipInterval to 1–120 seconds on both platforms.
  • Android icons: Use numbered skip icons when interval is 15; use new generic skip drawables for other values.
  • Documented the API, behavior, and platform notes in playback-notification-manager.mdx.
  • Demo in AudioFile example with skipInterval: 10 for manual testing.
  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@basiav basiav requested a review from mdydek July 14, 2026 12:30
Comment thread packages/audiodocs/docs/system/playback-notification-manager.mdx Outdated
Comment thread packages/audiodocs/docs/system/playback-notification-manager.mdx Outdated
Comment thread packages/audiodocs/docs/system/playback-notification-manager.mdx Outdated
Comment thread apps/common-app/src/examples/AudioFile/AudioFile.tsx
Comment thread packages/react-native-audio-api/src/system/notification/types.ts
@basiav

basiav commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

Applied review suggestions:

  • Removed comments
  • Removed inline comment from skipInterval in types.ts
  • Default (15) and clamp (1–120) are now handled in PlaybackNotificationManager.show() before calling native
  • iOS/Android no longer duplicate validation logic — they only store and use the interval from JS
  • Docs updated to reflect that clamping happens in JavaScript.

Comment thread apps/common-app/src/examples/AudioFile/AudioFile.tsx
@basiav basiav merged commit 81dd29b into main Jul 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants