feat: audio latency#1129
Open
closetcaiman wants to merge 31 commits into
Open
Conversation
maciejmakowski2003
requested changes
Jul 10, 2026
maciejmakowski2003
requested changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1104
Introduced changes
Important
Identified race condition between
oboebackground thread (invokingonErrorAfterClose()) and any other thread that accessesmStream_-> serialized it via locks (recursive_mutexexactly for clearer locking flow)Audio Thread running
onAudioReadydoes not require locks and thus stays consistent with no-locking policyAudioContextinterface with spec by addingbaseLatencyandoutputLatencyinputLatencytoAudioRecorder(React Native extension, not in spec)AVAudioSession(iOS) and Oboe (Android)AudioContextandAudioRecorderwith native source detailsChecklist