Decouple duration test from presentation timing - #46
Merged
Merged
Conversation
Assisted-By: devx/e18eafa2-2efa-46c8-8c94-fb459f0d557f
samuel-williams-shopify
force-pushed
the
fix-duration-test-fixture
branch
from
September 16, 2026 22:09
bb1af91 to
50e0d2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a dedicated temporary slide fixture for the duration parsing assertion. This keeps recorded timing changes to the bundled presentation from invalidating the test suite.