Skip to content

Stabilize recorder controls - #43

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
stabilize-recorder-navigation
Sep 16, 2026
Merged

Stabilize recorder controls#43
samuel-williams-shopify merged 1 commit into
mainfrom
stabilize-recorder-navigation

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • keep narration controls persistent while navigating between slides
  • model loading, missing, present, recording, review, and transient operation states explicitly
  • render the control interface in a client-owned shadow DOM while exposing canonical slide state as host attributes
  • back <presently-recording-controls> with an independently resolvable Live RecordingControlsView
  • render recording availability server-side and cancel stale playback, recording, save, and duration operations
  • rename the full recording interface to RecorderView and align the client/server control names
  • preserve stable control dimensions and transitions without initial or navigation layout flicker

Validation

  • git diff --check
  • npm test — 23 tests passed
  • bundle exec bake test — 235 tests passed, 484 assertions

@samuel-williams-shopify
samuel-williams-shopify force-pushed the stabilize-recorder-navigation branch 3 times, most recently from 47321f4 to 8211c3b Compare September 16, 2026 10:51
@samuel-williams-shopify samuel-williams-shopify changed the title Stabilize recorder slide navigation Stabilize recorder controls Sep 16, 2026
@samuel-williams-shopify
samuel-williams-shopify force-pushed the stabilize-recorder-navigation branch 4 times, most recently from baf59de to 463179b Compare September 16, 2026 11:20
@samuel-williams-shopify
Stabilize recorder controls
3a8e121 
Render persistent recording controls in a Live-backed shadow DOM, model their states explicitly, and resolve the nested view independently.

Assisted-By: OpenAI Codex <noreply@openai.com>
Assisted-By: devx/e18eafa2-2efa-46c8-8c94-fb459f0d557f
@samuel-williams-shopify
samuel-williams-shopify merged commit dd1d82d into main Sep 16, 2026
28 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the stabilize-recorder-navigation branch September 16, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samuel-williams-shopify