Document form handling - #17
Closed
samuel-williams-shopify wants to merge 2 commits into
Closed
samuel-williams-shopify wants to merge 2 commits into
samuel-williams-shopify wants to merge 2 commits into
Conversation
Signed-off-by: Samuel Williams <samuel.williams@shopify.com> Assisted-By: devx/7ef83274-928f-499d-b668-48449b1ff60e
Signed-off-by: Samuel Williams <samuel.williams@shopify.com> Assisted-By: devx/7ef83274-928f-499d-b668-48449b1ff60e
Contributor
Author
|
Closing because the documented interface depended on socketry/live-js#6. We will retain instead. |
Contributor
Author
|
Clarification: closing because the documented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document form submission using
Live::Element#forward_form_event, including the forwarded event shape, repeated form controls, submit-button values, and normal HTTP fallback.Add the example form to the resolver used by the getting-started guide. This keeps form handling within the existing view/event model rather than introducing a specialized
Live::Form.Uses the Ruby-style
event[:form_data]interface introduced by socketry/live-js#6, which should merge first.Fixes #4.
Testing
ruby -con the documentedContactFormexamplebundle exec bake decode:index:coverage libbundle exec sus test/live/element.rb test/live/page.rb test/live/resolver.rb test/live/view.rb