Keep the Fiber alive across rb_fiber_transfer() - #225
Closed
tavianator wants to merge 1 commit into
Closed
tavianator wants to merge 1 commit into
tavianator wants to merge 1 commit into
Conversation
Recently I was debugging a SIGSEGV that showed an rb_fiber_t that had been entirely overwritten by JSON text. In tracing it down I found Ruby bug #22196 which seems like a likely cause. Since that fix hasn't made it into a released version of Ruby, add a workaround to `fiber.c` which adds a GC guard for the fiber to keep it alive across the call. Link: https://bugs.ruby-lang.org/issues/22196 Link: ruby/ruby#17957
Contributor
|
Fixed versions of Ruby should be released this month, possibly in the next few days. If that's the case, let's wait for that instead. |
Member
|
New releases dropped today with the fixes. I propose we update those instead (proper fix). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I was debugging a SIGSEGV that showed an rb_fiber_t that had
been entirely overwritten by JSON text. In tracing it down I found
Ruby bug #22196 which seems like a likely cause. Since that fix hasn't
made it into a released version of Ruby, add a workaround to
fiber.cwhich adds a GC guard for the fiber to keep it alive across the call.
Link: https://bugs.ruby-lang.org/issues/22196
Link: ruby/ruby#17957
Types of Changes
Contribution