Map HTTP/2 body INTERNAL_ERROR to RemoteError - #236
samuel-williams-shopify wants to merge 2 commits into
Conversation
|
any blockers to merging this? |
|
No, let me do a final pass over these changes. |
04a760d to
aa6d0fd
Compare
|
After the final review, we're closing this PR and addressing the Faraday integration directly in socketry/async-http-faraday#61. This PR normalizes one known body-read failure, but it does not establish a useful general retry contract. The benefit here is consistency with the existing pre-response The companion PR will retain support for the already-released This closes the proposed abstraction change, not the original bug report: #231 remains open while the Faraday fix is completed. Thanks for the detailed traces and review, and sorry for the delay in reaching this decision. |
Summary
This complements the pre-response mapping added in #232. Once response headers have resolved readiness, a later reset surfaces from the body and cannot safely be retried inside Async::HTTP::Client. Normalizing it as RemoteError lets integrations apply their own retry policy.
Testing
Fixes #231