Repository navigation
fix(cluster-engine): publish a Buffer to Redis from the primary - #5637
Open
NotAFlightRisk wants to merge 1 commit into
Open
NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
Set up as in the README's "Node.js cluster & Redis" example, the primary crashes the first time it passes a message on, and the client just gets a
connect_error.setupPrimaryWithRedis()hands msgpack'sUint8Arraystraight topublish(), and node-redis only takes a string or a Buffer:TypeError: "arguments[2]" must be of type "string | Buffer", got object insteadThat's redis 6.3.1 with @socket.io/cluster-engine 0.1.1 (redis 4.7.1 says
Invalid argument typeinstead).New behavior
It goes through
Buffer.from()first, likeRedisEnginealready does further down the same file, and the example works.Other information (e.g. related issues)
I haven't added a test, since nothing covers
setupPrimaryWithRedis()yet and a proper one needs a cluster and Redis running.