Repository navigation
docs: point the build badges of the parser and client packages to the monorepo - #5636
Merged
darrachequesne merged 1 commit intoNov 17, 2026
Merged
Conversation
Member
|
Good catch, thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
The build badges in three package READMEs still point to the
CIworkflow of the old standalone repositories, which no longer serves a badge (the image URL returns 404, so the badge shows as a broken image on GitHub and npm):packages/socket.io-client/README.md->socketio/socket.io-client/workflows/CI/badge.svgpackages/socket.io-parser/Readme.md->socketio/socket.io-parser/workflows/CI/badge.svgpackages/engine.io-parser/Readme.md->socketio/engine.io-parser/workflows/CI/badge.svgNew behavior
Each badge now points to the package's workflow in this monorepo (
ci-socket.io-client.yml,ci-socket.io-parser.yml,ci-engine.io-parser.yml), the same format theengine.ioandengine.io-clientREADMEs already use.Other information (e.g. related issues)
Checked with
curl: the three old badge URLs return 404; the three new badge URLs and the workflow pages they link to return 200.