Skip to content

docs: point the build badges of the parser and client packages to the monorepo - #5636

Merged
darrachequesne merged 1 commit into
socketio:mainfrom
farisbasha:docs/monorepo-build-badges
Nov 17, 2026
Merged

darrachequesne merged 1 commit into
socketio:mainfrom
farisbasha:docs/monorepo-build-badges

Conversation

@farisbasha

Copy link
Copy Markdown
Contributor

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

The build badges in three package READMEs still point to the CI workflow of the old standalone repositories, which no longer serves a badge (the image URL returns 404, so the badge shows as a broken image on GitHub and npm):

  • packages/socket.io-client/README.md -> socketio/socket.io-client/workflows/CI/badge.svg
  • packages/socket.io-parser/Readme.md -> socketio/socket.io-parser/workflows/CI/badge.svg
  • packages/engine.io-parser/Readme.md -> socketio/engine.io-parser/workflows/CI/badge.svg

New behavior

Each badge now points to the package's workflow in this monorepo (ci-socket.io-client.yml, ci-socket.io-parser.yml, ci-engine.io-parser.yml), the same format the engine.io and engine.io-client READMEs already use.

Other information (e.g. related issues)

Checked with curl: the three old badge URLs return 404; the three new badge URLs and the workflow pages they link to return 200.

@darrachequesne
darrachequesne merged commit cbbcb19 into socketio:main Nov 17, 2026
@darrachequesne

Copy link
Copy Markdown
Member

Good catch, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants