ci(docker): smoke-test the image before publishing it#330
Merged
Conversation
The deploy job now builds the native amd64 image locally (--load) from the downloaded artifact and runs the smoke test before pushing anything, so a broken image can never reach the registry. The build job's smoke test can't catch artifact-level issues (e.g. the executable bit lost through the artifact round-trip) because it builds the binary locally, not from the artifact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Smoke-test the container image before publishing it, so a broken image can never reach the registry.
The deploy job now, in
make deploy-docker:linux/amd64image locally (--load) from the downloaded artifact,/version, the embedded UI, and a mock round-trip),Why
The
buildjob already smoke-tests an image, but it builds the binary locally — it never exercises the GitHub artifact round-trip that the deploy job does. That gap let a real bug ship:actions/upload-artifactdoesn't preserve the executable bit, so the binary the deploy job packaged was0644and the publishedscratchimage failed at startup with/smocker ... not executable(fixed in the Dockerfile viaCOPY --chmod=0755). This pre-push smoke closes the gap by testing the exact artifact that gets published.Extends the docker smoke-testing from #68 to the publish path.
Verified
make -n deploy-dockershows nothing is pushed before the smoke passes; locally, building the amd64 image from a deliberately0644binary and running the smoke succeeds (serves the UI + mock 200).🤖 Generated with Claude Code