Fix runtime trait IDs - #817
Merged
Merged
Conversation
Correct the default, idempotency token, and unit type trait IDs so schemas resolve typed traits and operation token metadata correctly. Add three regression tests and a bugfix entry.
jonathan343
force-pushed
the
fix/runtime-trait-ids
branch
from
September 28, 2026 05:54
8f2ecc5 to
1afadd4
Compare
jonathan343
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the registered IDs for
DefaultTrait,IdempotencyTokenTrait, andUnitTypeTraittosmithy.api#default,smithy.api#idempotencyToken, andsmithy.api#unitType.Generated schemas already use these IDs, but the runtime registrations contain a namespace typo and incorrect capitalization. This causes default traits to resolve as
DynamicTraitand operation idempotency-token metadata to returnNone. TheUNITschema also stores its unit-type trait under an incorrect ID, so lookup by the canonical ID returnsNone.Add three regression tests that fail on
developand a bugfix entry. No generator changes or token autofill behavior are included.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.