Add native Python writer and import management - #816
Open
jonathan343 wants to merge 3 commits into
Open
jonathan343 wants to merge 3 commits into
jonathan343 wants to merge 3 commits into
Conversation
Render annotations and deterministic imports in memory. Verify emitted modules and resolved annotations.
Cover Python 3.12 through 3.15 with a fixed builtin-name set. Add regression tests and clarify local-name reservations.
Avoid self-imports and duplicate imports for equivalent Unicode spellings. Add runtime collision and builtin coverage tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Stacked on #815, targeting
feat/codegen-symbolsso this PR contains only the writer and import-management work.Summary
Adds
PythonWriterto render structured type references as Python annotations with deterministic imports and indentation. It handles nested and nullable types, forward references, builtin shadowing, and import-name collisions without renaming generated declarations or fields.The writer returns source in memory. Callers supply declaration and field names and write the module body. File output and structure generation remain separate follow-ups. The API and example are in
designs/codegen/writer.md.Example
Produces:
Additional Testing
Local rendering checks passed all 434 models in
aws/api-models-awsand all 24 inaws-sdk-python/codegen/aws-models, covering annotations, imports, compilation, and deterministic output. Streaming references produced the expected unsupported errors. These checks validate source rendering, not generated AWS classes, and do not add an external CI dependency.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.