Add dynamic-client end-to-end test against real Connect model#1234
Draft
yasmewad wants to merge 1 commit into
Draft
Add dynamic-client end-to-end test against real Connect model#1234yasmewad wants to merge 1 commit into
yasmewad wants to merge 1 commit into
Conversation
Loads the production AWS Connect model (DescribeContact,
GET /contacts/{InstanceId}/{ContactId}) and exercises the full
DynamicClient -> RestJsonClientProtocol -> PathSerializer path via a
capturing transport (no credentials or network), asserting the two
@httpLabel path variables serialize correctly.
This is an end-to-end smoke test for the dynamic-client path. Note: it
does NOT reproduce the original ClassCastException on its own, because
DocumentUtils.getMemberValue (since 4ec73e9) unwraps a string label via
asObject() before PathSerializer sees it. The unit-level PathSerializerTest
remains the regression guard for the cast bug; this test guards the
dynamic-client integration end to end.
Adds smithy-aws-endpoints as a test dependency so the real Connect model
(endpointBdd / aws.partition) assembles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loads the production AWS Connect model (DescribeContact, GET /contacts/{InstanceId}/{ContactId}) and exercises the full DynamicClient -> RestJsonClientProtocol -> PathSerializer path via a capturing transport (no credentials or network), asserting the two @httpLabel path variables serialize correctly.
This is an end-to-end smoke test for the dynamic-client path. Note: it does NOT reproduce the original ClassCastException on its own, because DocumentUtils.getMemberValue (since 4ec73e9) unwraps a string label via asObject() before PathSerializer sees it. The unit-level PathSerializerTest remains the regression guard for the cast bug; this test guards the dynamic-client integration end to end.
Adds smithy-aws-endpoints as a test dependency so the real Connect model (endpointBdd / aws.partition) assembles.
What behavior changes?
Describe the observable difference in behavior before and after this change.
Why is this change needed?
Explain the motivation: bug, feature request, refactor, performance, etc.
How was this validated?
List tests added, benchmarks run, or manual verification performed.
What should reviewers focus on?
Point reviewers to the files or sections that contain the interesting logic.
Additional Links
Related issues, design docs, or prior art.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.