Surface API error messages and standardize HTTP status fallback messages#146
Merged
Conversation
This was referenced Jun 10, 2026
Merged
andyjohnsonsmarty
requested changes
Jun 16, 2026
andyjohnsonsmarty
left a comment
andyjohnsonsmarty
left a comment
Contributor
There was a problem hiding this comment.
Add a test that checks how non-enrichment-apis handle 304, they should return a positive result
HttpSender returns null for an empty body (no JSON.parse throw), and the batch / us_autocomplete_pro / us_extract clients tolerate a null payload, so a 304 yields an empty result instead of throwing.
andyjohnsonsmarty
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the standard error message scheme shared across all Smarty SDKs: every HTTP error status now surfaces the message from the API's JSON error body (
{"errors":[{"message":"..."}]}) when one is present, and falls back to the standard per-status message list otherwise (304, 400, 401, 402, 403, 408, 413, 422, 429, 500, 502, 503, 504, plus an "unexpected status code" default).In this SDK
DefaultError); addedForbiddenError/RequestTimeoutError/BadGatewayError.nameso it survives minification and duplicate package copies;rejected.statusCodeis unchanged for property-based checks.instanceof DefaultErrorchecks for 4xx statuses will no longer match; use the specific classes,error.name, orstatusCode.Validation
Related PRs (same change in every SDK)