[PLEX - 3243] - Stellar chain service GetLedgers#2243
Conversation
|
👋 ilija42, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
There was a problem hiding this comment.
Pull request overview
This PR extends the Stellar relayer/service surface area to support a new GetLedgers RPC, including domain types, gRPC plumbing, proto conversions, and tests to validate round-trips and error propagation.
Changes:
- Added
GetLedgersto the Stellar service interfaces (domain + loop gRPC) and provided unimplemented/default implementations. - Introduced new domain + proto types for ledger pagination and ledger info, plus proto<->domain conversion helpers.
- Added tests covering the new unimplemented method behavior and end-to-end gRPC round-trips/conversion error cases.
Reviewed changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/relayer.go | Adds GetLedgers stub to UnimplementedStellarService. |
| pkg/types/relayer_stellar_test.go | Tests UnimplementedStellarService.GetLedgers returns codes.Unimplemented. |
| pkg/types/mocks/stellar_service.go | Extends StellarService mock with GetLedgers. |
| pkg/types/chains/stellar/stellar.go | Adds domain API/types for GetLedgers + pagination + ledger info. |
| pkg/loop/internal/relayerset/stellar.go | Wires GetLedgers through relayerset gRPC server/client wrappers. |
| pkg/loop/internal/relayer/stellar.go | Adds GetLedgers to the loop relayer client/server bridging logic. |
| pkg/loop/internal/relayer/stellar_test.go | Adds gRPC round-trip tests for GetLedgers (success + impl error). |
| pkg/chains/stellar/stellar.proto | Adds GetLedgers RPC and related request/response/messages. |
| pkg/chains/stellar/stellar.pb.go | Regenerated proto types to include new messages. |
| pkg/chains/stellar/stellar_grpc.pb.go | Regenerated gRPC stubs to include GetLedgers. |
| pkg/chains/stellar/proto_helpers.go | Adds proto/domain conversion helpers for GetLedgers types. |
| pkg/chains/stellar/proto_helpers_test.go | Adds conversion round-trip + error-path tests for new types. |
| pkg/capabilities/v2/chain-capabilities/stellar/client.pb.go | Updates generated comments to align with updated proto docs. |
Files not reviewed (4)
- pkg/capabilities/v2/chain-capabilities/stellar/client.pb.go: Generated file
- pkg/chains/stellar/stellar.pb.go: Generated file
- pkg/chains/stellar/stellar_grpc.pb.go: Generated file
- pkg/types/mocks/stellar_service.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Requires
Supports
smartcontractkit/chainlink-stellar#142