Skip to content

[PLEX - 3243] - Stellar chain service GetLedgers#2243

Merged
ilija42 merged 5 commits into
mainfrom
PLEX-3243-stellar-cs-getLedgerAt
Jul 14, 2026
Merged

[PLEX - 3243] - Stellar chain service GetLedgers#2243
ilija42 merged 5 commits into
mainfrom
PLEX-3243-stellar-cs-getLedgerAt

Conversation

@ilija42

@ilija42 ilija42 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 13, 2026 14:46
@ilija42 ilija42 requested review from a team as code owners July 13, 2026 14:46
@github-actions

Copy link
Copy Markdown
Contributor

👋 ilija42, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (3)

pkg/chains/stellar.StellarClient (1)
  • GetLedgers — ➕ Added
pkg/types/chains/stellar.Client (2)
  • GetLedgers — ➕ Added

  • GetLedgers — ➕ Added

✅ Compatible Changes (21)

pkg/chains/stellar (11)
  • ConvertGetLedgersRequestFromProto — ➕ Added

  • ConvertGetLedgersRequestToProto — ➕ Added

  • ConvertGetLedgersResponseFromProto — ➕ Added

  • ConvertGetLedgersResponseToProto — ➕ Added

  • ConvertLedgerInfoFromProto — ➕ Added

  • ConvertLedgerInfoToProto — ➕ Added

  • GetLedgersRequest — ➕ Added

  • GetLedgersResponse — ➕ Added

  • LedgerInfo — ➕ Added

  • LedgerPaginationOptions — ➕ Added

  • Stellar_GetLedgers_FullMethodName — ➕ Added

pkg/chains/stellar.StellarServer (1)
  • GetLedgers — ➕ Added
pkg/chains/stellar.UnimplementedStellarServer (1)
  • GetLedgers — ➕ Added
pkg/types.(*UnimplementedStellarService) (1)
  • GetLedgers — ➕ Added
pkg/types/chains/stellar (4)
  • GetLedgersRequest — ➕ Added

  • GetLedgersResponse — ➕ Added

  • LedgerInfo — ➕ Added

  • LedgerPaginationOptions — ➕ Added

pkg/types/mocks (1)
  • StellarService_GetLedgers_Call — ➕ Added
pkg/types/mocks.(*StellarService) (1)
  • GetLedgers — ➕ Added
pkg/types/mocks.(*StellarService_Expecter) (1)
  • GetLedgers — ➕ Added

📄 View full apidiff report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Stellar relayer/service surface area to support a new GetLedgers RPC, including domain types, gRPC plumbing, proto conversions, and tests to validate round-trips and error propagation.

Changes:

  • Added GetLedgers to the Stellar service interfaces (domain + loop gRPC) and provided unimplemented/default implementations.
  • Introduced new domain + proto types for ledger pagination and ledger info, plus proto<->domain conversion helpers.
  • Added tests covering the new unimplemented method behavior and end-to-end gRPC round-trips/conversion error cases.

Reviewed changes

Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/types/relayer.go Adds GetLedgers stub to UnimplementedStellarService.
pkg/types/relayer_stellar_test.go Tests UnimplementedStellarService.GetLedgers returns codes.Unimplemented.
pkg/types/mocks/stellar_service.go Extends StellarService mock with GetLedgers.
pkg/types/chains/stellar/stellar.go Adds domain API/types for GetLedgers + pagination + ledger info.
pkg/loop/internal/relayerset/stellar.go Wires GetLedgers through relayerset gRPC server/client wrappers.
pkg/loop/internal/relayer/stellar.go Adds GetLedgers to the loop relayer client/server bridging logic.
pkg/loop/internal/relayer/stellar_test.go Adds gRPC round-trip tests for GetLedgers (success + impl error).
pkg/chains/stellar/stellar.proto Adds GetLedgers RPC and related request/response/messages.
pkg/chains/stellar/stellar.pb.go Regenerated proto types to include new messages.
pkg/chains/stellar/stellar_grpc.pb.go Regenerated gRPC stubs to include GetLedgers.
pkg/chains/stellar/proto_helpers.go Adds proto/domain conversion helpers for GetLedgers types.
pkg/chains/stellar/proto_helpers_test.go Adds conversion round-trip + error-path tests for new types.
pkg/capabilities/v2/chain-capabilities/stellar/client.pb.go Updates generated comments to align with updated proto docs.
Files not reviewed (4)
  • pkg/capabilities/v2/chain-capabilities/stellar/client.pb.go: Generated file
  • pkg/chains/stellar/stellar.pb.go: Generated file
  • pkg/chains/stellar/stellar_grpc.pb.go: Generated file
  • pkg/types/mocks/stellar_service.go: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/chains/stellar/proto_helpers.go
@ilija42 ilija42 enabled auto-merge July 14, 2026 11:09
@ilija42 ilija42 added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit f33a971 Jul 14, 2026
31 of 33 checks passed
@ilija42 ilija42 deleted the PLEX-3243-stellar-cs-getLedgerAt branch July 14, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants