Remove KeyUsageCertSign requirement for X5C provisioner roots - #1680
Open
mmustafasenoglu wants to merge 1 commit into
Open
Remove KeyUsageCertSign requirement for X5C provisioner roots#1680mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
The CLI enforced that X5C root certificates must have the KeyUsageCertSign extension, but the step-ca API does not require this. A self-signed certificate without KeyUsageCertSign can successfully authenticate via --x5c-cert/--x5c-key flags, so the CLI should not reject it during provisioner creation. Closes smallstep#1329
github-actions
Bot
added
the
needs triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1329
The CLI enforced that X5C root certificates must have the
KeyUsageCertSignextension, but the step-ca API does not require this. A self-signed certificate withoutKeyUsageCertSigncan successfully authenticate via--x5c-cert/--x5c-keyflags, so the CLI should not reject it during provisioner creation.This removes the
KeyUsageCertSigncheck from bothcreateX5CDetails()inadd.goandupdateX5CDetails()inupdate.go, aligning the CLI behavior with the API.As noted in the issue: the only requirement from the API is that the client certificate has
Digital Signaturein its Key Usage so it can sign tokens. The root certificate validation during provisioner creation is overly strict compared to what the API actually enforces.