perf: Reduce ancestry calls in isResourceMethod - #2631
Open
Postremus wants to merge 1 commit into
Open
Conversation
ancestry determines the parent methods the given method is overriden. Which in turn are checked if they are a resource method. However, often the resource methods are not overriding any parent methods. so the ancestry call would be wasted. ancestry() is slow (relativly speaking) because of the interfaces() calls. Introduce a fast path for first checking if the given method is already resource method, before falling back to checking ancestry.
Postremus
force-pushed
the
issues/2630-improve-isResourceMethod
branch
from
August 15, 2026 16:35
03d02f9 to
3a5fba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ancestry determines the parent methods the given method is overriden. Which in turn are checked if they are a resource method.
However, often the resource methods are not overriding any parent methods. so the ancestry call would be wasted.
ancestry() is slow (relativly speaking) because of the interfaces() calls.
Introduce a fast path for first checking if the given method is already resource method, before falling back to checking ancestry.
This saves about 100ms when doing a quarkus:build.
Related to #2630