Repository navigation
feat(skills): gloss each mode word in the slash picker description - #52
Merged
Merged
Conversation
The picker shows name plus description only, so a bare word list told the user the words exist but not what they do. Give each of the six a half-line plain-language gloss in both editions; the mapping table stays owned by the body.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slash picker shows name plus description only. f6781a8 moved the mode
words into the description, but a bare word list still says the words exist
without saying what they do — the mapping stayed in the body, one click away
from the only surface where the words are typed.
Give each of the six words a half-line plain-language gloss, in both editions,
on the line the picker renders:
The mapping table stays owned by the body; the description points at it rather
than re-copying it.
Tests:
node --test test/skill.test.js test/skill-mirror.test.js— 12 pass.Full suite on this branch: 339 tests, 338 pass + 1 skip, 0 fail (the skip is
the bsdtar-keyed exploit expectation; this machine's PATH resolves tar to GNU
tar 1.35, the recorded split).