chore: track undici-types to the resolved undici version#652
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 8 8
Lines 731 731
=======================================
Hits 730 730
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The overrides pin held undici-types at ^7.28.0 while undici is a direct dependency that Dependabot bumps independently. Because undici-types is pulled in transitively by @types/node, the runtime library and its type declarations could drift apart on a major bump. Use the "$undici" override so undici-types always resolves to whatever version undici resolves to, keeping them in lockstep automatically on every future bump. $undici resolves to the current 7.28.0, so the lockfile is unchanged; the behavior only activates when undici bumps. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
The group existed to bump undici and undici-types together in one PR. Now that the "$undici" override resolves undici-types to the undici version automatically, undici can bump as a normal ungrouped PR and the types follow via the override. The group is redundant. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
5bfda53 to
dc5e0b0
Compare
The failing unit-test run merged this branch against the old base (the undici@8 branch, #648) because the pull/652/merge ref was stale after retargeting the PR to main. Against main (undici@^7.28.0) the committed lockfile satisfies the "$undici" override and npm ci passes. This empty commit regenerates the merge ref so CI runs against main. Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
zimeg
added
bug
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
👻 A note of reference for readers so kind!
| "overrides": { | ||
| "undici-types": "^7.28.0" | ||
| "undici-types": "$undici" | ||
| }, |
There was a problem hiding this comment.
📣 note: This syntax is used to match earlier versions:
// BEST, the override is defined as a reference to the dependency
// the referenced package does not need to match the overridden one
🔗 https://docs.npmjs.com/cli/v12/configuring-npm/package-json#overrides
|
🔍 Will fast merge now to confirm with #648! |
1 participant
Summary
This pull request makes
undici-typesfollowundiciautomatically and removes the now-redundant Dependabot group.overridesblock pinnedundici-typesto^7.28.0whileundiciis a direct dependency that Dependabot bumps independently (e.g. build(deps): bump undici from 7.28.0 to 8.7.0 in the undici group across 1 directory #648 movesundicito 8.x). Becauseundici-typesis pulled in transitively by@types/node, the runtime library and its type declarations could drift apart on a major bump."$undici"override resolvesundici-typesto whatever versionundiciresolves to, keeping them in lockstep automatically on every future bump.undicigroup (which existed to bumpundici+undici-typestogether) is redundant, so it is removed.undicibumps now arrive as normal ungrouped PRs and the types follow via the override.$undiciresolves to7.28.0today (same as the old pin), so the lockfile is unchanged; the new behavior activates whenundicibumps.Testing
undicito^8.7.0, runnpm install, and confirmnpm ls undici undici-typesshows both resolving to8.7.0(the override tracks undici to 8.x, overriding@types/node's declared~7.18.0).Requirements
🤖 Generated with Claude Code