Skip to content

5 threads (for the default singleton) can be created even when SlackConfig#statsEnabled is false #987

Description

@seratch

Developers can disable API clients' metrics management by setting SlackConfig#statsEnabled to false. Even in this case, the default SlackConfig object creation (as a static field in the class) starts 5 threads and those threads are unused. See the repro steps below for details.

Reproducible in:

any versions

The Slack SDK version

any versions

Java Runtime version

any versions

OS info

any versions

Steps to reproduce:

Running the following code and checking the thread dump.

SlackConfig config = new SlackConfig();
config.setStatsEnabled(false);
Slack slack = Slack.getInstance(config);

Expected result:

No threads under a "slack-api-metrics" thread group are created.

Actual result:

5 threads for the default singleton SlackConfig instance are created.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions