Skip to content

Raise clearer errors in case of failed requests#15

Open
Emerichenon wants to merge 3 commits into
sishen:masterfrom
Emerichenon:better-fail-patch
Open

Raise clearer errors in case of failed requests#15
Emerichenon wants to merge 3 commits into
sishen:masterfrom
Emerichenon:better-fail-patch

Conversation

@Emerichenon

Copy link
Copy Markdown

No description provided.

@AnkurGel

AnkurGel commented Sep 4, 2016

Copy link
Copy Markdown
Collaborator

@Emerichenon Few tests break. Also, probably it's not a good idea to raise Uber::Error::BadRequest for every failure code. Making some changes :) // cc @sishen

@sishen

sishen commented Sep 4, 2016

Copy link
Copy Markdown
Owner

@Emerichenon The error response will raise Farady::Error::ClientError. You can construct a friendly Uber::Error object in Client.rb#L138. Would you mind to update your PR there? Thank you.

@gabriel-dehan

gabriel-dehan commented Sep 4, 2016

Copy link
Copy Markdown

@AnkurGel Actual author here was working on a student's computer on a tight schedule while helping him with an uber relatied project. I'll make sure the tests passes or are you fixing it ?

@sishen Sure, we did not have much time so I didn't do the best fix in the world, I'll update it next week.

Cheers :)

@AnkurGel

AnkurGel commented Sep 4, 2016

Copy link
Copy Markdown
Collaborator

@sishen @gabriel-dehan Made some changes related to this here : #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants