chore(deps): bump reqwest 0.12→0.13 in the Rust SDK#351
Merged
Conversation
reqwest 0.13 isn't a clean version-only bump for the generated client: - `query` is now an opt-in crate feature; the client uses .query() (x2), so it's added to the feature list. - the `rustls-tls` reqwest feature was renamed to `rustls`; the SDK's optional rustls-tls feature now maps to reqwest/rustls. Default feature stays native-tls (unaffected). Note: reqwest 0.13's rustls backend now pulls aws-lc-rs (needs a C toolchain + cmake at build time) instead of ring — only affects consumers that enable rustls-tls. Verified locally (JS CI does not cover /sdks/rust): cargo build (default native-tls) -> ok, reqwest 0.13.4 cargo build --no-default-features --features rustls-tls -> ok cargo test -> 0 tests (generated SDK) Supersedes #322.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts reqwest 0.13 in the generated Rust client (
/sdks/rust). Dependabot's #322 was version-only, but 0.13 has breaking feature changes that need adaptation:queryis now an opt-in crate feature (was implicit in 0.12). The generated client calls.query()(×2), soqueryis added to the feature list — otherwise it fails to compile.rustls-tlsreqwest feature was renamed torustls. The SDK's optionalrustls-tlsfeature now maps toreqwest/rustls.Default feature stays
native-tls(still valid in 0.13), so default consumers are unaffected.Verification (local — JS CI doesn't cover
/sdks/rust)cargo build(default native-tls) — ok, reqwest 0.13.4cargo build --no-default-features --features rustls-tls— ok (aws-lc-sys built)cargo test— 0 tests (generated SDK has none)Supersedes #322 (closed as superseded on merge).