Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR)
Addresses #1572. Configuring a literal withArgs stub after a broader matcher currently mutates the matcher fake, so calls with other arguments receive the literal's behavior. This also affects reset and filtered spy history.
Require equality in both directions before reusing a configuration. Use the existing public comparator and retain the matcher-aware invocation path. The extra comparison runs only while registering a forward-matched configuration.
How to verify
The local Ubuntu host requires the repository driver's CI mode for Chromium sandbox settings. Browser tests ran with CI=1 and PUPPETEER_EXECUTABLE_PATH pointing to Chrome 149. Lint retains the existing Browserslist notice; dependency checking retains five existing Knip hints.
Authored with Codex assistance; the reported failure was reproduced and the submitted source was tested locally.
Checklist for author