Repository navigation
Read asctime Retry-After dates as UTC - #6
Merged
sinnercode228 merged 1 commit intoNov 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read an asctime
Retry-Afteras UTC so a 429 waits the requested time instead of falling back to jitter. Recognize the exact asctime layout before adding the implicit zone; other zone-less dates, including-0000, remain ignored.Fixes #4. This follows RFC 9110 §5.6.7. Both READMEs and the next-version Unreleased changelog are updated.
Validation: 365 tests pass; four added regression cases failed before the fix (three asctime date forms and a mocked client retry). Coverage includes past dates, RFC 850/IMF-fixdate parity, invalid dates and existing zone-less rejection.
ruff check,ruff format --check,mypy --strict src,mypy, wheel/sdist build,twine check --strictandgit diff --checkpass on Python 3.12. No requests went to a live amoCRM account.Implemented and reviewed with OpenAI Codex assistance.