fix issue with --limit not working correctly - #698
Open
shahzebsiddiqui wants to merge 1 commit into
Open
Conversation
Member
|
Setting limit to 0 is normally akin to unset (no limit). Asking for a limit of 0 and getting no results is not something that user would logically do. My preference is either to keep limit of 0 to mean no limit, or if the user defines is to be <1, to print a quick error message that the limit must be greater than or equal to 1 and then exit cleanly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@vsoch the original codebase doesnt honor the
--limitcorrectly as shown below.With
--limit 1i should see 1 entryAlso with
--limit 0i end up seeing more entries so this doesnt work eitherWith the proposed change i was able to fix this as shown below