feat(api): tenant-scoped sender and provider configuration - #90
Open
patoperpetua wants to merge 1 commit into
Open
feat(api): tenant-scoped sender and provider configuration#90patoperpetua wants to merge 1 commit into
patoperpetua wants to merge 1 commit into
Conversation
Add per-tenant email configuration loaded from App Configuration so sends use the authenticated tenant's from/reply-to settings without accepting sender fields from request bodies. Closes #35 Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TENANT_EMAIL_CONFIG_BY_ID(App Configuration:app:email:tenantConfigById) to resolve per-tenant/environmentfromAddress,fromDisplayName, andreplyToserver-side, merged with platformEMAIL_FROM_*defaults.send.tsto use resolved tenant sender identity; request-body sender/reply-to fields are ignored. Missing tenant config returns stableTENANT_CONFIG_NOT_FOUND.providerAccountviaTENANT_PROVIDER_ACCOUNT_SECRETS(Key Vault-backed env var references). Append troubleshooting row for the new error code.Closes #35
Test plan
pnpm -r --if-present run testpassessend.tenant-sender.spec.ts)TENANT_CONFIG_NOT_FOUNDwithout leaking another tenant's senderMade with Cursor