fix: quote package test globs so Node expands them - #78
Conversation
Shell expansion of unquoted src/**/*.spec.ts silently skips specs at mixed depths; quote the glob in all packages/*/test scripts to match apps/api. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe package test scripts now quote their specification globs. Node’s test runner receives each glob without shell expansion. ChangesPackage test glob quoting
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change makes nested package tests expand consistently without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description includes the linked issue, summary, rationale, test results, nested-spec verification, lint, and build checks. It omits the template's separate Feedback focus and Automated checks sections, but the required information is mostly present. Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Summary
src/**/*.spec.ts(and.tsxin editor) in all sixpackages/*/package.jsontestscripts so Node's--testrunner expands the glob instead of the shell.apps/apiand prevents silently skipped specs when a package has tests at mixed directory depths.Test plan
pnpm test— all packages report the same test counts as before (email 95, client 9, compiler 12, types 4, editor 4, publisher 8, api 160)src/sub/throwaway-depth.spec.tsinpost-kit-clientran with quoted glob, then removedpnpm lintandpnpm buildpass locallyCloses #71
Made with Cursor
Summary by CodeRabbit