feat(publisher): persist compile manifest as manifest.json blob - #74
feat(publisher): persist compile manifest as manifest.json blob#74patoperpetua wants to merge 1 commit into
Conversation
Upload the compiled TemplateManifest alongside template.html and metadata.json so deployed templates retain provenance after CI logs expire, without changing the send path or existing stdout log line. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughTemplate publishing now stores ChangesTemplate manifest publishing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds a non-send-path manifest.json blob while preserving the existing template blobs and stdout format; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Publisher
participant BlobStorage
participant TemplateAPI
Publisher->>BlobStorage: Upload template.html and metadata.json
Publisher->>BlobStorage: Upload manifest.json as application/json
Publisher-->>Publisher: Emit one structured summary line
TemplateAPI->>BlobStorage: Read template.html and metadata.json
BlobStorage-->>TemplateAPI: Return template content and metadata
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description includes the linked issue, change summary, test commands, compatibility impact, and documentation impact. It omits the template's detailed setup, step-by-step expected results, feedback focus, and Automated checks heading, but the core information is complete. Full details: Linked Issues checkExplanation The changes satisfy issue Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Summary
manifest.jsonas a third blob under each template prefix (tenants/{tenant}/{env}/templates/{key}/manifest.json) withapplication/json; charset=utf-8, containingcontentHash,compiledAt,sourceCommit, and related compile manifest fields.BlobTemplateStorestill reads onlytemplate.htmlandmetadata.json.docs/guides/template-publishing.mdto document the new blob and its operational (non-send-path) role.Closes #69
Test plan
pnpm --filter @singleton-sd/post-kit-publisher test— asserts manifest blob path, content type, payload fields, and unchanged stdout shapepnpm --filter @singleton-sd/post-kit-compiler testpnpm -r --if-present run testMade with Cursor
Summary by CodeRabbit
New Features
manifest.jsonfile alongside the HTML and metadata.application/jsoncontent type.Bug Fixes