Repository navigation
fix(api): attribute a polled run's failure only to the block that caused it - #9916
Merged
Merged
Conversation
…sed it A run's stored error was paired with any failed block in its trace when the message classified as a generic failure, so a run-level fault or a branch that failed after the settling error reported an unrelated block. The trace read now names a block only when its name heads the run error or its recorded error is exactly it, which keeps unprefixed loop and parallel failures attributed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryThis PR limits failed-run block attribution to blocks whose name or recorded error matches the run error.
No actionable issues found. Review was source-based; no tests were run.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the release PR #9912 review threads on the agent API work.
Summary
BLOCK_EXECUTION_FAILEDwith an unrelated block. A block is now named only when it owns the run's error: its name heads the error (Block name: message) or its own recorded error is exactly the run error. Otherwise the run reportsEXECUTION_FAILEDwith no block.Test plan