Repository navigation
fix(tables): show rejected filter errors in the grid and fill imports to the row limit - #9881
Merged
Merged
Conversation
… to the row limit
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; both earlier findings are fixed and no new actionable issues were found. SummaryThe PR shows rejected row-query errors in the grid and lets streaming CSV imports fill the table to its plan limit.
Reviews (2) · Last reviewed commit: "fix(tables): use caption size for the gr..." · Reviewed by Greptile |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1,000on a number column with a range operator) used to look identical to "no rows match", becauseuseTablenever read the query's error. Only a failed first page shows it; a failed next page or background refetch keeps the loaded rowsImport stopped at this table's row limit (N rows) on your current plan. M rows were imported; the rest of the file was not.) and persists that count as progress. Appending to a table that is already full still fails with the existing row-limit error and inserts nothingTableRowLimitError's wordingType of Change
Testing
lib/table/import-runner.test.ts: 5 new row-limit cases (crossing batch fills to the limit, batch landing exactly on the limit with rows left, append counts existing rows, already-full table inserts nothing, file that exactly fills completes). 4 of them fail against the pre-fix runner, and reverting each new guard (partial-batch slice, imported-count error, progress write before the stop) turns at least one test redhooks/use-table.test.tspassesbiome checkon changed files; full type-check, audits and suite left to CIChecklist
test-auditauthoring gate)