[waleedlatif1]

Summary

Follow-up to #9655 and #9666, from a final review of the release branch.

• Fill capacity in selection order. The claim cut ranked every selected owner's candidates by revision age, so with less free capacity than candidates (any loaded pass) a woken owner selected first could lose every slot to an older backlog selected after it. The claim then stamped it, filing it behind the rotation. Claims now fill capacity owner by owner in the pass's selection order, each still up to its free slots; ties within an owner keep revision age. lockFileSearchOwners sorts by key for lock order, so the selection order is restored from the candidates before claiming.
• Wake a reaped owner the backfill just queued. Both phases run in one transaction, backfill first, so an owner the page queued as a reconciliation wake-up (stamped last_dispatched_at = now()) absorbed the reaper's wake-up (updated_at = now(), so updated_at > last_dispatched_at was false) and the released claim waited behind the rotation. A wake that conflicts with a row stamped by this same transaction now clears the stamp, exactly as if the wake had queued the owner first; a stamp from an earlier transaction is always older than now(), so nothing else changes. The phase order stays backfill → reap, which keeps the pass's lock order file → queue row, the same order a file save's trigger takes.
• TSDoc on wokenSinceDispatch now lists the artifact-ready requeue and states the write-overlapping-a-claim window accurately; README describes the free-slot condition and the fill order; one stale test comment.

Not changed (noted for later): owner selection no longer walks file_search_dispatch_schedule_idx since #9666 (a top-N sort over the queue each pass); a partial index on woken rows plus a two-statement select would restore index order but needs a migration and buys nothing at current queue sizes. Using clock_timestamp() in the file trigger would close the write-overlapping-a-claim window; also a migration.

Type of Change

• Bug fix

Testing

• dispatcher.integration.ts (real PostgreSQL):
  • fills the free capacity in selection order, so a woken owner is not outbid by an older backlog — red on the previous code and with the revision-age cut restored
  • keeps a reaped claim woken when the backfill queues its owner in the same pass — red on the previous code and with the stamp reset removed
  • leaveSlots now deletes its filler owner's files so the backfill never re-queues it (removes a tie-break dependence on owner ids)
• Suite 42/42; owners.integration 18/18, chunks.integration 49/49 (1 opt-in skip), index-plan.integration 9/9, content-rendered.integration 31/31, lib/workspace-files/search unit tests 178/178
• lint and type-check (pre-push hooks); remaining audits in CI

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing (new tests pass the test-audit authoring gate)
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 4, 2026 10:47am UTC

[cubic-dev-ai]

No issues found across 3 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issue was found.

Summary

The dispatcher fills available slots in owner selection order and keeps recovered claims ahead of ordinary queued work.

• File-search claims follow owner selection order.
• Reaped claims stay near the front when backfill runs too.

The previous thread was unnumbered, so it has no entry in previousFindings. Its reported lock cycle is addressed. Tests were inspected, not run.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Backfill missing revisions] --> B[Queue owners for reconciliation]
  B --> C[Release expired claims]
  C --> D[Clear same-pass stamp for recovered owners]
  D --> E[Select owners with free slots]
  E --> F[Acquire owner locks]
  F --> G[Restore selection order]
  G --> H[Fill available slots owner by owner]

Loading

_{Reviews (2) · Last reviewed commit: "fix(file-search): keep the dispatch pass..." · Reviewed by Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 3 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}