Repository navigation
fix(resume): carry the admitted resume run's ID on outer resume failure logs - #9663
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This change appears safe to merge. SummaryAdds the admitted resume run’s
No actionable issues found. Review was based on source inspection; no runtime checks were run. Reviews (1) · Last reviewed commit: "fix(resume): carry the admitted resume r..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catchinexecuteResumeWorkflownow includes the admitted resume run'sresumeExecutionIdwhen it logs a failure. Failures afterenqueueOrStartResumeadmits the resume can reach thatcatchwithout another boundary logging them with the child run's ID, for example the streaming request guard or amarkResumeFailed/markResumeAttemptFailedfault on the synchronous path. Those can now be tied to the resumed run.enqueueResult, not the local preprocessingresumeExecutionId, which is never the admitted run. A failure before admission logs without it, as before.logFailureOncestill keys on the paused run'sexecutionId, so failures the manager already logged are still skipped.Type of Change
Testing
biome checkon the changed fileundefinedfield: the JSON line (JSON.stringify) and the OTel attributes (filterUndefined). A pre-admission failure therefore logs exactly what it did before.Checklist
test-auditauthoring gate)