Skip to content

fix(resume): carry the admitted resume run's ID on outer resume failure logs - #9663

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/resume-log-admitted-run-id
Nov 4, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/resume-log-admitted-run-id

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The outer catch in executeResumeWorkflow now includes the admitted resume run's resumeExecutionId when it logs a failure. Failures after enqueueOrStartResume admits the resume can reach that catch without another boundary logging them with the child run's ID, for example the streaming request guard or a markResumeFailed/markResumeAttemptFailed fault on the synchronous path. Those can now be tied to the resumed run.
  • The ID comes from enqueueResult, not the local preprocessing resumeExecutionId, which is never the admitted run. A failure before admission logs without it, as before.
  • Deduplication is unchanged: logFailureOnce still keys on the paused run's executionId, so failures the manager already logged are still skipped.

Type of Change

  • Bug fix

Testing

  • biome check on the changed file
  • Confirmed both logger paths drop an undefined field: the JSON line (JSON.stringify) and the OTel attributes (filterUndefined). A pre-admission failure therefore logs exactly what it did before.
  • Type-check, audits and the Vitest suites run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 4, 2026 9:31am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This change appears safe to merge.

Summary

Adds the admitted resume run’s resumeExecutionId to outer failure logs in executeResumeWorkflow.

  • Resume failure logs identify the admitted run.

No actionable issues found. Review was based on source inspection; no runtime checks were run.

Reviews (1) · Last reviewed commit: "fix(resume): carry the admitted resume r..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit ef70aa7 into staging Nov 4, 2026
80 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 3a1a50fc Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant