Repository navigation
fix(webhooks): answer missing trigger configuration with 400 and stop logging refused resumes as errors - #9659
Merged
waleedlatif1 merged 2 commits intoNov 4, 2026
Conversation
…refused resumes at warn
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge, with a non-blocking mismatch in the resume refusal log level. Findings
SummaryThe PR separates missing webhook settings from provider failures.
Reviews (2) · Last reviewed commit: "fix(webhooks): type blank Plane tokens a..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 32 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
… config errors, dedupe resume refusal logs
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebhookDeploymentConfigurationErrorwhen a user-supplied trigger field is missing or malformed at subscription creation. That covers API keys, IDs, subdomains, hosts, trigger type, and the selected credential. It is the class HelpScout, QuickBooks and Zoho Desk already use.POST /api/webhooksanswers that error with a 400 and logs it at warn. Any other subscription failure is still a 500. This is the same rule the deploy path already applies inwebhookConfigFailureStatus, so a deploy with one of these errors now fails terminally with a 400 instead of retrying a 500.catchblocks pass the config error through without logging it at error a second time.planeWebhookRequestrejects a blank or CR/LF-containing token, and Airtable readsbaseId/tableIdwithtoStringOrNull, so these malformed values also get the 400 instead of a crash or a 500.executeResumeWorkflowlogs throughlogFailureOnce, keyed on the paused run, so a failure the manager already logged is not logged again. A refusal below 500, such as a 409 when the pause is already resumed, is marked auserfailure and logs at info. 5xx and statusless errors still log at error. The thrown error and its status are unchanged.Type of Change
Testing
biome checkon every changed fileChecklist
test-auditauthoring gate)