[waleedlatif1]

Summary

• Creating a Sim link from the answer's sources popover opened the form beneath the popover. Popovers stack above modals by design (--z-popover > --z-modal) so they can open inside dialogs, and the form was mounted inside the popover's row. SimLinkOrganizationProvider now hosts the new-link form at the layout root: the row's menu calls useOpenSimLinkForm, the form mounts outside the popover, takes focus, and the popover dismisses itself. The z-index scale is unchanged
• The file share dialog keeps its nested form (a dialog inside a dialog already stacks and keeps its focus trap)
• Name suggestions keep only letters and digits, joined by single hyphens: "Sim: Build and govern…" now suggests sim-build-and-govern… instead of sim:-build-and-govern…

Type of Change

• Bug fix

Testing

• message-sources.test.tsx drives the real path (open sources popover → row actions → Create Sim link, lookup stubbed empty) and asserts the form opens prefilled while the popover is gone; it fails on the previous code with the popover still showing
• validation.test.ts: colons, dots and other name punctuation become single hyphens
• Affected suites green (247 tests: sim-links, links page, share modal, message content, search results)

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing (new tests pass the test-audit authoring gate)
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 4, 2026 2:28am UTC

[cubic-dev-ai]

No issues found across 6 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Moves the source menu’s new-link form to SimLinkOrganizationProvider and suggests names made of letters, digits, and hyphens.

• Source menus open the new-link form outside the sources popover.
• Suggested Sim-link names replace punctuation runs with single hyphens.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Source actions menu] --> B[useOpenSimLinkForm]
  B --> C[Provider stores draft]
  C --> D[Root form opens]
  D --> E[Sources popover dismisses]

Loading

_{Reviews (3) · Last reviewed commit: "test(sim-links): import the macrotask he..." · Reviewed by Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 6 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 6 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}