Repository navigation
improvement(cli): recovery guidance on every parse error and body-shape refusal - #9646
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues remain. SummaryThe PR adds command-specific recovery guidance for parse errors and rejected JSON body shapes.
Reviews (2) · Last reviewed commit: "fix(cli): valid JSON recovery examples, ..." · Reviewed by Greptile |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This was referenced Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
files upload,files ls, ...) used to answer a guessed flag with a bareunknown option. Guidance now wraps each command's ownerror, because.command()children share their parent's output-configuration object, so a formatter set on one command would answer for all of themtables rows list --filter→tables rows query — Query rows with a filter and sort). Commander's near-spelling suggestion never reaches across commandsfiles rename <id> new.pdf→pass it as --name "new.pdf",knowledge search <kbId>→--kb)knowledge search "<query>" --kb <id>)--rows/--data): the error says what shape it received, gives an example, and points at the right spelling. That covers the wrapper object{"rows":[...]}, a single row passed to--rows, and an array passed to--data. Nothing is reshaped--help/referenceor dropped the filter and pulled whole tables into jq. Missing-flag positionals recovered in one round about 85% of the time;--rowsshape errors failed again on the next call about 44% of the timeType of Change
Testing
embed-isolation.test.tscases cover each failure mode throughrunEmbeddedCli. Both fail on the pre-fix code and pass after the fixpackages/sim-clivitest (521 tests),tsc --noEmit, biome on the changed filesChecklist
test-auditauthoring gate)